Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves re-login experience. Closes #342 #358

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 22, 2024

🎯 Aim

The aim improve and simplify login behavior for SPFx Toolkit and try to fixup a strange issue with login output when cli command is executed.

πŸ“· Result

// TODO

βœ… What was done

  • updated login method from device code to browser to simplified the process
  • added saving clientId and tenantId to global state
  • sign out user upon error when executing CLI command with login message

πŸ”— Related issue

Closes #342

@Adam-it Adam-it linked an issue Nov 22, 2024 that may be closed by this pull request
@Adam-it Adam-it self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ’‘ [Feature]: Improve re-login experience
1 participant